On Sun, May 16, 2021 at 7:08 AM David Bremner <david@tethera.net> wrote: > > Felipe Contreras <felipe.contreras@gmail.com> writes: > > > In order to fit the git coding style. > > > > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com> > > I personally prefer this style, but I have to point out that the C and > C++ code in the code base (including the Ruby bindings) use the > "brace-on-the-next-line" style. Should we strive for consistency with > the C code, or is there some overriding concern here? I consistently code in C, Ruby, shell, Python, and Javascript. Each one has different idioms, and in each one people tend to have different styles. For example in C people tend to use tabs of 8 spaces, in Python 4, and in Ruby 2. I personally have different styles depending on the language, and I don't know any project that tries to be consistent among languages. The testing framework for example seems to come from the git project, which has a C style of: void function(void) { } But a shell style of: function () { } I may have been spoiled by them, but I like both styles. Additionally the testing framework was split into the sharness project [1], which obviously has the same shell style. BTW, at some point you might want to use sharness, instead of maintaining your own testing framework. So my vote is no: we should not strive with consistency with the C code. The original git shell style is fine, and if we adopt it, we can refer to it in test/README instead of defining our own. Cheers. [1] https://github.com/chriscool/sharness -- Felipe Contreras _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org