Felipe Contreras <felipe.contreras@gmail.com> writes: > The testing framework for example seems to come from the git project, > which has a C style of: > > void function(void) > { > } > > But a shell style of: > > function () { > } I looked at the existing code, and it does seem to mostly use the latter style. So I guess this change is less disruptive than flipping everything the other way. > I may have been spoiled by them, but I like both styles. Additionally > the testing framework was split into the sharness project [1], which > obviously has the same shell style. BTW, at some point you might want > to use sharness, instead of maintaining your own testing framework. That would depend how much work is involved in porting 17k+ lines of tests. > So my vote is no: we should not strive with consistency with the C > code. The original git shell style is fine, and if we adopt it, we can > refer to it in test/README instead of defining our own. Here again I'd want to see how much change to the test suite is necessary to conform. I noticed a few things (like the location of "then") where we don't currently follow the git shell style very closely. d _______________________________________________ notmuch mailing list -- notmuch@notmuchmail.org To unsubscribe send an email to notmuch-leave@notmuchmail.org