Re: [PATCH v4 03/16] make shared crypto code behave library-like

Subject: Re: [PATCH v4 03/16] make shared crypto code behave library-like

Date: Fri, 12 Aug 2016 16:46:52 +0900

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

>  lib/notmuch.h   | 17 +++++++++++

It seems this patch needs rebasing, it doesn't apply anymore (and my git
the data to do it easily).  Reviewing it statically, the patch looks ok.

• Previous message (by thread): Re: [PATCH] WIP: remove all non-prefixed-terms (and stemmed versions)

Thread:

• Daniel Kahn Gillmor—Allow indexing cleartext of encrypted messages (v4) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, signed, unread]
        • David Bremner—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
            • Tomi Ollila—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
              • David Bremner—Re: [PATCH v4 01/16] add util/search-path.{c, h} to test for executables in $PATH [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 02/16] Move crypto.c into libutil [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 02/16] Move crypto.c into libutil [inbox, unread]
    • David Bremner—Re: [PATCH v4 02/16] Move crypto.c into libutil [inbox, unread]
      • Tomi Ollila—Re: [PATCH v4 02/16] Move crypto.c into libutil [inbox, unread]
        • David Bremner—Re: [PATCH v4 02/16] Move crypto.c into libutil [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 03/16] make shared crypto code behave library-like [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v4 03/16] make shared crypto code behave library-like [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 05/16] Choose the default gpg_path with _notmuch_crypto_get_gpg_path (NULL) [inbox, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v4 06/16] Prefer gpg2 in the test suite if available [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v4 06/16] Prefer gpg2 in the test suite if available [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 07/16] create a notmuch_indexopts_t index options object [inbox, notmuch::patch, notmuch::stale, unread]
  • Daniel Kahn Gillmor—[PATCH v4 08/16] reorganize indexing of multipart/signed and multipart/encrypted [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 08/16] reorganize indexing of multipart/signed and multipart/encrypted [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 09/16] index encrypted parts when asked. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 09/16] index encrypted parts when asked. [inbox, unread]
      • Daniel Kahn Gillmor—Re: [PATCH v4 09/16] index encrypted parts when asked. [inbox, unread]
        • David Bremner—Re: [PATCH v4 09/16] index encrypted parts when asked. [inbox, unread]
          • Daniel Kahn Gillmor—Re: [PATCH v4 09/16] index encrypted parts when asked. [inbox, signed, unread]
    • David Bremner—Re: [PATCH v4 09/16] index encrypted parts when asked. [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 10/16] Add n_d_add_message_with_indexopts (extension of n_d_add_message) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 11/16] add --try-decrypt to notmuch insert [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v4 11/16] add --try-decrypt to notmuch insert [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 12/16] add --try-decrypt to notmuch new [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 12/16] add --try-decrypt to notmuch new [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 13/16] add indexopts to notmuch python bindings. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 13/16] add indexopts to notmuch python bindings. [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 14/16] test indexing cleartext version of delivered messages. [inbox, notmuch::patch, notmuch::stale, unread]
    • David Bremner—Re: [PATCH v4 14/16] test indexing cleartext version of delivered messages. [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 15/16] added notmuch_message_reindex [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—[PATCH] WIP: remove all non-prefixed-terms (and stemmed versions) [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH] WIP: remove all non-prefixed-terms (and stemmed versions) [inbox, unread]
  • Daniel Kahn Gillmor—[PATCH v4 16/16] add "notmuch reindex" subcommand [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Bremner—Re: [PATCH v4 16/16] add "notmuch reindex" subcommand [inbox, unread]
      • Olly Betts—Re: [PATCH v4 16/16] add "notmuch reindex" subcommand [inbox, unread]