Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path

Subject: Re: [PATCH v4 04/16] Provide _notmuch_crypto_{set,get}_gpg_path

Date: Fri, 12 Aug 2016 17:04:20 +0900

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

From: David Bremner

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:


> +notmuch_status_t
> +_notmuch_crypto_set_gpg_path (_notmuch_crypto_t *crypto, const char *gpg_path)
> +{
[snip]
> +    if (! gpg_path && ! test_for_executable (gpg_path))
> +	return NOTMUCH_STATUS_FILE_ERROR;

this looks strange. Maybe the "!" in front of gpg_path might be
spurious. Or maybe you mean || ?

> -    const char *gpgpath;
> +    char *gpg_path;
>  } _notmuch_crypto_t;

Why is const dropped here?
>

Thread: