Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes: > This prepares us for using the crypto object in both the library and > the client. > > i've prefixed notmuch_crypto with _ to indicate that while this can be > built into the library when needed, it's not something to be exported > or used externally. I started to review this series on top of [1], but I didn't get much past here because of the build failure. I guess there will be at least one more small change needed because of the alternative way I ended up doing "remove all properties". I find % git rebase -i -x "make test" an effective way of making sure things are in a good state after every patch. At least it's effective when I remember to do it; just before writing this, I discovered a rebasing error in [1] that caused a similar build failure. [1]: id:1470491559-3946-1-git-send-email-david@tethera.net