Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

Date: Wed, 15 Jun 2011 07:06:40 -0700

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> I have just send two more patches to this thread.  One with new tests.
> Another with a workaround for the bug.  The workaround should not break
> anything since it affects only notmuch-show mode.

Thanks!

I love committing tests that demonstrate broken code before committing
fixes. As it happened here, I committed these two new patches thinking I
had previously committed the earlier patches in the series. Fortunately,
the failure of the test pointed out that I was missing the actual fix.

I also really like the workaround to avoid regressing functionality
because of an emacs bug.

Well done, Dmitry. I've now pushed out everything in this series.

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: