On Wed, 15 Jun 2011 07:06:40 -0700, Carl Worth <cworth@cworth.org> wrote: > On Fri, 27 May 2011 01:42:22 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote: > > I have just send two more patches to this thread. One with new tests. > > Another with a workaround for the bug. The workaround should not break > > anything since it affects only notmuch-show mode. > > Thanks! > > I love committing tests that demonstrate broken code before committing > fixes. As it happened here, I committed these two new patches thinking I > had previously committed the earlier patches in the series. Fortunately, > the failure of the test pointed out that I was missing the actual fix. > I know you prefer tests to go before patches and I agree with that. But most of the time I do tests after coding. I do not know an easy way to reorder patches in git. (Also I do not know how to amend an old patch, wish more darcs features in git.) Hopefully it is not a big trouble for you to reorder the patches when applying. > I also really like the workaround to avoid regressing functionality > because of an emacs bug. > indeed > Well done, Dmitry. I've now pushed out everything in this series. > Thanks. Regards, Dmitry > -Carl > > -- > carl.d.worth@intel.com