Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

Subject: Re: [PATCH 3/5] Fix hiding a message while some citations are shown in notmuch-show view.

Date: Thu, 26 May 2011 02:34:28 +0400

To: Carl Worth, notmuch@notmuchmail.org

Cc:

From: Dmitry Kurochkin


On Wed, 25 May 2011 15:23:47 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Thu, 26 May 2011 02:10:14 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Before the change, message and citation invisibility overlays
> > conflicted: if some citation is made visible and then the whole
> > message is hidden, that citation remained visible.
> 
> That sounds like quite a bug. I'd love to see this series also add a
> test case for that.
> 

I am not sure how it is best to test this.  The common `printc' method
for emacs tests does not work, because it prints invisible parts as
well.  We need either to find a way to print only visible text on the
console, or test it inside emacs somehow.  Any suggestions?

Note that this is exactly the patch that hits the isearch emacs bug.  Do
I understand correctly that you are ready to push the series despite of
it (given that we have a test)?

Regards,
  Dmitry

> -Carl
> 
> -- 
> carl.d.worth@intel.com
Non-text part: application/pgp-signature

Thread: