Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller

Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller

Date: Tue, 05 Nov 2013 12:15:19 +0100

To: David Bremner, notmuch@notmuchmail.org

Cc:

On Tue, 05 Nov 2013, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> +    backup_path = talloc_asprintf (config, "%s/xapian.old", path);
>> +    if (! backup_path)
>> +	return 1;
>> +
>
> Is it intentional that no message is printed here? A random glance at
> notmuch-search.c suggests we usually print a message on OOM in the CLI.

Oversight.

Jani.

Previous message (by thread): Re: [PATCH 1/2] cli: add compact --quiet option and silence output with it

Thread:

Jani Nikula—[PATCH v2 00/11] compactor changes v2 [inbox, unread]
- Jani Nikula—[PATCH v2 01/11] test: fix compact backup / restore test [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 02/11] lib: construct compactor within try block to catch any exceptions [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 03/11] lib: check talloc success in compact [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 03/11] lib: check talloc success in compact [inbox, unread]
- Jani Nikula—[PATCH v2 04/11] lib: do not leak the database in compaction [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 05/11] lib: add closure parameter to compact status update callback [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 06/11] lib: update documentation of callback functions for database_compact and database_upgrade. [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 07/11] lib: use the compaction backup path provided by the caller [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller [inbox, unread]
    - Jani Nikula—Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller [inbox, unread]
- Jani Nikula—[PATCH v2 08/11] cli: return error status if compaction fails [inbox, notmuch::patch, notmuch::pushed, unread]
- Jani Nikula—[PATCH v2 09/11] cli: add compact --backup=DIRECTORY option, don't backup by default [inbox, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH v2 09/11] cli: add compact --backup=DIRECTORY option, don't backup by default [inbox, unread]
- Jani Nikula—[PATCH v2 10/11] cli: add compact --verbose option and silence output without it [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Jani Nikula—[PATCH 1/2] cli: add compact --quiet option and silence output with it [inbox, notmuch::patch, notmuch::pushed, unread]
    - Jani Nikula—[PATCH 2/2] man: document notmuch compact --quiet and --backup=DIRECTORY options [inbox, notmuch::patch, notmuch::pushed, unread]
      - Tomi Ollila—Re: [PATCH 2/2] man: document notmuch compact --quiet and --backup=DIRECTORY options [inbox, notmuch::review, unread]
    - David Bremner—Re: [PATCH 1/2] cli: add compact --quiet option and silence output with it [inbox, unread]
- Jani Nikula—[PATCH v2 11/11] man: document notmuch compact --verbose and --backup=DIRECTORY options [inbox, notmuch::obsolete, notmuch::patch, unread]
- David Bremner—Re: [PATCH v2 00/11] compactor changes v2 [inbox, unread]
  - Tomi Ollila—Re: [PATCH v2 00/11] compactor changes v2 [inbox, unread]
    - Ben Gamari—Re: [PATCH v2 00/11] compactor changes v2 [inbox, signed, unread]
      - Tomi Ollila—Re: [PATCH v2 00/11] compactor changes v2 [inbox, unread]
- Ben Gamari—Re: [PATCH v2 00/11] compactor changes v2 [inbox, signed, unread]