Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

Subject: Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

Date: Sun, 10 Apr 2016 21:33:02 -0300

To: Daniel Kahn Gillmor, Notmuch Mail

Cc:

Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:

> To fully complete the ghost-on-removal-when-shared-thread-exists
> proposal, we need to clear all ghost messages when the last active
> message is removed from a thread.

For me this patch breaks T530 as follows

T530-upgrade: Testing database upgrade
 FAIL   ghost message retains thread ID
	--- T530-upgrade.13.expected	2016-04-11 00:25:19.482196274 +0000
	+++ T530-upgrade.13.output	2016-04-11 00:25:19.482196274 +0000
	@@ -1 +1 @@
	-thread:000000000000001d
	+thread:0000000000000011
No new mail.
No new mail. Removed 1 message.

I pushed my rebased version of the patches to

  https://git.notmuchmail.org/git?p=notmuch;a=shortlog;h=refs/heads/thread-fix

in case the problem is some mistake on my part.

d

Previous message (by thread): Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists

Thread:

Daniel Kahn Gillmor—[PATCH] test thread breakage when messages are removed and re-added [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—Re: [PATCH] test thread breakage when messages are removed and re-added [inbox, signed, unread]
- Daniel Kahn Gillmor—[PATCH 1/2] verify during thread-breakage that messages are removed as well [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH 2/2] fix thread breakage via ghost-on-removal [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v2 1/7] test thread breakage when messages are removed and re-added [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v2 2/7] verify during thread-breakage that messages are removed as well [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 2/7] verify during thread-breakage that messages are removed as well [inbox, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v2 2/7] verify during thread-breakage that messages are removed as well [inbox, unread]
  - Daniel Kahn Gillmor—[PATCH v2 3/7] fix thread breakage via ghost-on-removal [inbox, notmuch::obsolete, notmuch::patch, unread]
    - Tomi Ollila—Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal [inbox, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal [inbox, signed, unread]
        David Bremner—Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal [inbox, unread]
    - David Bremner—Re: [PATCH v2 3/7] fix thread breakage via ghost-on-removal [inbox, unread]
  - Daniel Kahn Gillmor—[PATCH v2 4/7] Add internal functions to search for alternate doc types [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 4/7] Add internal functions to search for alternate doc types [inbox, unread]
  - Daniel Kahn Gillmor—[PATCH v2 5/7] Introduce _notmuch_message_has_term() [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—Re: [PATCH v2 5/7] Introduce _notmuch_message_has_term() [inbox, unread]
  - Daniel Kahn Gillmor—[PATCH v2 6/7] On deletion, replace with ghost when other active messages in thread [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v2 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—[PATCH 1/2] test thread breakage when messages are removed and re-added [inbox, notmuch::obsolete, notmuch::patch, unread]
    - David Bremner—[PATCH 2/2] test: add test-binary to print the number of ghost messages [inbox, notmuch::obsolete, notmuch::patch, notmuch::wip, unread]
- Daniel Kahn Gillmor—[PATCH v3 1/7] test: add test-binary to print the number of ghost messages [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 2/7] test thread breakage when messages are removed and re-added [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 3/7] fix thread breakage via ghost-on-removal [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 4/7] Add internal functions to search for alternate doc types [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 5/7] Introduce _notmuch_message_has_term() [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 6/7] On deletion, replace with ghost when other active messages in thread [inbox, notmuch::obsolete, notmuch::patch, unread]
  - Daniel Kahn Gillmor—[PATCH v3 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, notmuch::obsolete, notmuch::patch, unread]
- Daniel Kahn Gillmor—[PATCH v4 1/7] test: add test-binary to print the number of ghost messages [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—[PATCH v4 2/7] test thread breakage when messages are removed and re-added [inbox, notmuch::patch, notmuch::pushed, unread]
    - Daniel Kahn Gillmor—[PATCH] remove debugging spew from T590 [inbox, unread]
  - Daniel Kahn Gillmor—[PATCH v4 3/7] fix thread breakage via ghost-on-removal [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—[PATCH v4 4/7] Add internal functions to search for alternate doc types [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—[PATCH v4 5/7] Introduce _notmuch_message_has_term() [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—[PATCH v4 6/7] On deletion, replace with ghost when other active messages in thread [inbox, notmuch::patch, notmuch::pushed, unread]
  - Daniel Kahn Gillmor—[PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, notmuch::patch, notmuch::pushed, unread]
    - David Bremner—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
        David Bremner—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
    - Tomi Ollila—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
    - David Bremner—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
      - Daniel Kahn Gillmor—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, signed, unread]
        David Bremner—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
        David Bremner—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
        Austin Clements—Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists [inbox, unread]
  - David Bremner—Re: [PATCH v4 1/7] test: add test-binary to print the number of ghost messages [inbox, unread]