Re: [PATCH v2 2/7] verify during thread-breakage that messages are removed as well

Subject: Re: [PATCH v2 2/7] verify during thread-breakage that messages are removed as well

Date: Fri, 08 Apr 2016 22:54:31 -0300

To: David Bremner, Notmuch Mail

Cc:

From: Daniel Kahn Gillmor


On Tue 2016-04-05 22:20:45 -0300, David Bremner wrote:
> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
>
>>  
>> +test_subject_count() {
>> +    notmuch new >/dev/null
>> +    test_begin_subtest "${3:-looking for $2 instance of '$1'}"
>> +    count=$(notmuch count --output=threads "$1")
>> +    test_expect_equal "$count" "$2"
>> +}
>
> It's confusing that this doesn't have anything to do with the subject:
> prefix or the corresponding header.

Sigh.  sorry, i just realized i missed this absolutely correct comment
when preparing the v3 series.  v4 is on its way, and hopefully it
addresses all the excellent feedback i got here.

apologies for the noise.

       --dkg

Thread: