Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Subject: Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Date: Sat, 19 Jul 2014 09:34:31 -0300

To: W. Trevor King

Cc: notmuch@notmuchmail.org

From: David Bremner


"W. Trevor King" <wking@tremily.us> writes:

> On Wed, Jul 16, 2014 at 07:36:10PM -0300, David Bremner wrote:
>> W. Trevor King writes:
>> > If we don't have an upstream, there is nothing to merge, so
>> > nothing is unmerged.  This avoids errors like:
>> 
>> pushed this one patch.
>
> Without the stderr-catching of something like patch 3, this means
> folks without an upstream are going to see a distracting:
>
>   error: No upstream configured for branch 'master'
>

On reflection, I don't think that patch made things worse for this use
case. So I don't think it really hurts to leave it there for now.

d

Thread: