Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Subject: Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Date: Tue, 15 Jul 2014 20:44:53 -0300

To: W. Trevor King, notmuch@notmuchmail.org

Cc:

From: David Bremner

"W. Trevor King" <wking@tremily.us> writes:

> -  my $fetch_head = git ('rev-parse', $commit);
> +  my ($fetch_head, $status) = git_with_status ('rev-parse', $commit);
> +  if ($status) {
> +    return 0;
> +  }

Could there be other errors here, other than @{upstream} not existing?
At first glance it seems like there is potential to hide errors here.

d

Thread: