Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Subject: Re: [PATCH 2/4] nmbug: Handle missing @upstream in is_unmerged

Date: Thu, 17 Jul 2014 11:38:34 -0700

To: David Bremner

Cc: notmuch@notmuchmail.org

From: W. Trevor King


On Thu, Jul 17, 2014 at 06:28:55AM -0300, David Bremner wrote:
> W. Trevor King writes:
> > On Wed, Jul 16, 2014 at 07:36:10PM -0300, David Bremner wrote:
> >> W. Trevor King writes:
> >> > If we don't have an upstream, there is nothing to merge, so
> >> > nothing is unmerged.  This avoids errors like:
> >> 
> >> pushed this one patch.
> >
> > Without the stderr-catching of something like patch 3, this means
> > folks without an upstream are going to see a distracting:
> >
> >   error: No upstream configured for branch 'master'
> >
> > if they run 'nmbug status' without an @upstream.
> >
> > I'm working through the Python translation now ;).
> 
> Perhaps the best thing is to revert that patch then?

Sure.

Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
signature.asc (application/pgp-signature)

Thread: