Alexander Adolf <alexander.adolf@condition-alpha.com> writes:

> The issue I saw with S/MIME encrypted messages was, that the processing
> of the MIME tree stopped after decryption. It turned out there was no
> handler for application/(x-)?pkcs-mime type entities in notmuch-show.el,
> and the "handler of last resort" notmuch-show-insert-part-*/* was
> called. Thus, this patch just adds a notmuch-show handler for
> application/(x-)?pkcs-mime type entities.

Hi Alexander;

Thanks for sending that. It's a bit tricky to review SMIME stuff as I
believe none of the devs is really using SMIME regularly. One thing that
would help is adding one or more tests. Basically the test suite already
has a SMIME certificate, so if you can encrypt a message to that cert
(or use one of the existing ones), you can test that the message
displays OK in Emacs. The corresponding test set would probably be
T450-emacs-show, but it might be easier to add to T355-smime. Eventually
we'll also need a short update to doc/notmuch-emacs.rst.

I hope that helps move review forward,

David
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org