Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

Subject: Re: [PATCH] emacs/smime: render decrypted MIME entities in notmuch-show

Date: Wed, 06 Apr 2022 22:23:49 +0200

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Alexander Adolf


Hello David,

David Bremner <david@tethera.net> writes:

> [...]
> Thanks for sending that. It's a bit tricky to review SMIME stuff as I
> believe none of the devs is really using SMIME regularly. One thing that
> would help is adding one or more tests. Basically the test suite already
> has a SMIME certificate, so if you can encrypt a message to that cert
> (or use one of the existing ones), you can test that the message
> displays OK in Emacs. The corresponding test set would probably be
> T450-emacs-show, but it might be easier to add to T355-smime. Eventually
> we'll also need a short update to doc/notmuch-emacs.rst.
> [...]

Apologies for the delay in getting back to you, and thanks for the
pointers.

I have had a look to both files, and I _think_ T450-emacs-show would
seem more appropriate. It seems that T355-smime is more aimed at the
pure mechanics of en-/decryption, and the handling of that in
libnotmuch. Neither of these have been a problem for me.

Further looking at T450-emacs-show, I find that it uses a somewhat
extensive framework to implement its test cases. Any chances of giving
me a fast start with this, or will it be down to "use the source, Luke"?


Many thanks in advance and looking forward to your thoughts,

  --alexander
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: