Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

Subject: Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

Date: Fri, 08 Mar 2013 08:05:33 -0400

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> This allows specifying config file as a top level argument to notmuch,
> and generally makes it possible to override config file options in
> main(), without having to touch the subcommands.
>

I pushed patchs 5 through 7 of this 6 patch series.

- I'll see if I can figure out the elisp needed to work around the
  "Tramp stomped on my environment variables" problem.

- Is this NEWS worthy? 

- What about a unit test?

- What about updating the tests to use this feature, is that a good idea? 


d

• Previous message (by thread): Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

Thread:

• Jani Nikula—[PATCH v2 0/6] notmuch cli config changes [inbox, unread]
  • Jani Nikula—[PATCH v2 1/6] cli: abstract subcommand finding into a new function [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 2/6] cli: plug main notmuch command into subcommand machinery [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 3/6] cli: config: keep track of whether the config is newly created [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, unread]
      • Tomi Ollila—Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH v2 5/6] cli: move config open/close to main() from subcommands [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands [inbox, unread]
  • Jani Nikula—[PATCH v2 6/6] cli: add top level --config=FILE option [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH] man: document the notmuch --config=FILE global option [inbox, notmuch::patch, notmuch::pushed, unread]