Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only

Subject: Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only

Date: Thu, 07 Mar 2013 16:38:52 +0200

To: David Bremner, Jani Nikula, notmuch@notmuchmail.org

Cc:

From: Tomi Ollila

On Thu, Mar 07 2013, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>
>> We now have a notmuch_config_is_new() function to query whether a
>> config was created or not. Change the notmuch_config_open() is_new
>> parameter into boolean create_new to determine whether the function
>> should create a new config if one doesn't exist. This reduces the
>> complexity of the API.
>
> I have pushed the first 4 patches in this series. I'd like a second
> (third?) pair of eyes on 5/6.

The changes in 5/6 (and 6/6 & manpage) LGTM. Using config for the context
is good. The reply context of this mail has been produced by notmuch
with these patches applied.

> d

Tomi

• Previous message (by thread): Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands

Thread:

• Jani Nikula—[PATCH v2 0/6] notmuch cli config changes [inbox, unread]
  • Jani Nikula—[PATCH v2 1/6] cli: abstract subcommand finding into a new function [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 2/6] cli: plug main notmuch command into subcommand machinery [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 3/6] cli: config: keep track of whether the config is newly created [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, unread]
      • Tomi Ollila—Re: [PATCH v2 4/6] cli: config: make notmuch_config_open() "is new" parameter input only [inbox, notmuch::review, unread]
  • Jani Nikula—[PATCH v2 5/6] cli: move config open/close to main() from subcommands [inbox, notmuch::patch, notmuch::pushed, unread]
    • David Bremner—Re: [PATCH v2 5/6] cli: move config open/close to main() from subcommands [inbox, unread]
  • Jani Nikula—[PATCH v2 6/6] cli: add top level --config=FILE option [inbox, notmuch::patch, notmuch::pushed, unread]
  • Jani Nikula—[PATCH] man: document the notmuch --config=FILE global option [inbox, notmuch::patch, notmuch::pushed, unread]