Re: [PATCH] use notmuch_database_open_verbose

Subject: Re: [PATCH] use notmuch_database_open_verbose

Date: Sat, 12 Mar 2016 12:33:50 -0400

To: Patrick Totzke,


From: David Bremner

David Bremner <> writes:

>> -    """notmuch_database_open"""
>> -    _open = nmlib.notmuch_database_open
>> +    """notmuch_database_open_verbose"""
>> +    _open = nmlib.notmuch_database_open_verbose
>>      _open.argtypes = [c_char_p, c_uint, POINTER(NotmuchDatabaseP)]
>>      _open.restype = c_uint
> I expect you probably want to add the new binding, rather than replacing
> the old one. Otherwise updating the bindings will break all bindings
> using scripts.

Oh silly me. That's not actually exposed to the python API, so that's
fine. On the other hand, don't you want to update the argument types and
do something useful (throw an exception?) with the returned message?  As
it stands you lose information.