Re: [PATCH] use notmuch_database_open_verbose

Subject: Re: [PATCH] use notmuch_database_open_verbose

Date: Sun, 13 Mar 2016 09:37:40 -0300



From: David Bremner

Patrick Totzke <> writes:

> As far as I understand the bindings, the returned message is not needed
> because the return
> value of `Database._open` (line 212) contains information about the type of
> error that occurred.
> This is passed on two lines below if the open-call was unsuccessful.
> The docstrings for this method are not ideal (the mentioned "status"
> parameter is actually called "mode") but in terms of functionality it seems
> ok.

The error_message parameter (potentially) contains additional
information about an error. In any case, you're passing one too few
arguments to n_d_open_verbose, which doesn't seem like a good idea.