Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack

Subject: Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack

Date: Fri, 09 Sep 2016 21:53:58 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

From: David Bremner

Jani Nikula <jani@nikula.org> writes:

> -	if (mime_node_open (ctx, message, &(params->crypto), &root) == NOTMUCH_STATUS_SUCCESS) {
> -	    format_part_reply (root);
> -	    talloc_free (root);
> -	}
> +    g_object_unref (G_OBJECT (reply));
>  
> -	notmuch_message_destroy (message);
> +    if (mime_node_open (ctx, message, &params->crypto, &root) == NOTMUCH_STATUS_SUCCESS) {
> +	format_part_reply (root);
> +	talloc_free (root);

I'm not sure I should admit this, but I'd have to check a book to make
sure that &params->crypto is the same as &(params->crypto)

Thread: