Re: [PATCH v2 12/14] cli/reply: pass internet address list to munge detect

Subject: Re: [PATCH v2 12/14] cli/reply: pass internet address list to munge detect

Date: Sat, 10 Sep 2016 19:51:58 -0300

To: Jani Nikula, notmuch@notmuchmail.org

Cc:

Jani Nikula <jani@nikula.org> writes:

> ---
>  notmuch-reply.c | 20 ++++++++++++--------
>  1 file changed, 12 insertions(+), 8 deletions(-)

The commit message needs a bit more explanation. I think the writer
knows this code too well ;).
- This changes the arguments of reply_to_header_is redundant,
- "munge detect" is really only defined by a careful reading of comments.

Previous message (by thread): Re: [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers

Thread:

Jani Nikula—[PATCH v2 00/14] reply refactor, fixes [inbox, unread]
- Jani Nikula—[PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers [inbox, unread]
  - David Bremner—Re: [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers [inbox, unread]
    - Jani Nikula—Re: [PATCH v2 01/14] test: add known broken test for reply to message with multiple Cc headers [inbox, unread]
- Jani Nikula—[PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack [inbox, unread]
    - Jani Nikula—Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack [inbox, unread]
- Jani Nikula—[PATCH v2 03/14] cli/reply: reuse show_reply_headers() in headers-only format [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH v2 04/14] cli/reply: unify reply format functions [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 04/14] cli/reply: unify reply format functions [inbox, unread]
    - Jani Nikula—Re: [PATCH v2 04/14] cli/reply: unify reply format functions [inbox, unread]
- Jani Nikula—[PATCH v2 05/14] cli/reply: reorganize create_reply_message() [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 05/14] cli/reply: reorganize create_reply_message() [inbox, unread]
- Jani Nikula—[PATCH v2 06/14] cli/reply: make references header creation easier to follow [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 06/14] cli/reply: make references header creation easier to follow [inbox, unread]
- Jani Nikula—[PATCH v2 07/14] cli/reply: reuse create_reply_message() also for headers-only format [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH v2 08/14] cli/reply: reduce the reply format abstractions [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 08/14] cli/reply: reduce the reply format abstractions [inbox, unread]
- Jani Nikula—[PATCH v2 09/14] cli/reply: use dedicated functions for reply to mapping [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH v2 10/14] cli/reply: check for NULL list first in scan_address_list() [inbox, notmuch::obsolete, notmuch::patch, unread]
- Jani Nikula—[PATCH v2 11/14] cli/reply: return internet address list from get header funcs [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 11/14] cli/reply: return internet address list from get header funcs [inbox, unread]
- Jani Nikula—[PATCH v2 12/14] cli/reply: pass internet address list to munge detect [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 12/14] cli/reply: pass internet address list to munge detect [inbox, unread]
- Jani Nikula—[PATCH v2 13/14] cli/reply: pass gmime message to munge detection [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 13/14] cli/reply: pass gmime message to munge detection [inbox, unread]
- Jani Nikula—[PATCH v2 14/14] cli/reply: only pass gmime message to add recipients to reply message [inbox, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH v2 14/14] cli/reply: only pass gmime message to add recipients to reply message [inbox, unread]