Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack

Subject: Re: [PATCH v2 02/14] cli/reply: push notmuch reply format abstraction lower in the stack

Date: Sat, 10 Sep 2016 09:20:33 +0300

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Jani Nikula

On Sat, 10 Sep 2016, David Bremner <david@tethera.net> wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> -	if (mime_node_open (ctx, message, &(params->crypto), &root) == NOTMUCH_STATUS_SUCCESS) {
>> -	    format_part_reply (root);
>> -	    talloc_free (root);
>> -	}
>> +    g_object_unref (G_OBJECT (reply));
>>  
>> -	notmuch_message_destroy (message);
>> +    if (mime_node_open (ctx, message, &params->crypto, &root) == NOTMUCH_STATUS_SUCCESS) {
>> +	format_part_reply (root);
>> +	talloc_free (root);
>
> I'm not sure I should admit this, but I'd have to check a book to make
> sure that &params->crypto is the same as &(params->crypto)

Nah, you wouldn't have to check a book. If it weren't the same, it
wouldn't compile. :)

BR,
Jani.

Thread: