Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode

Subject: Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode

Date: Mon, 12 Dec 2022 15:22:11 +0000

To: David Bremner


From: Jose A. Ortega Ruiz

On Mon, Dec 12 2022, David Bremner wrote:

> jao <> writes:
>>> As mentioned in my previous reply, I'm still not 100% clear on why we
>>> need both depth and level.
>> i might be misremembering, but i think depth is just an auxiliarly
>> argument taken by that function to know whether it's inserting the tip
>> of a tree or not, not a real depth.  level is.  so a better way would be
>> to make 'depth' take the values 'level' is currently taking, but i
>> wasn't sure other code would be using depth with its old original
>> meaning (e.g. via and advice; i did at some point).
> depth is used for indentation in notmuch-show-mode, so it should be
> (close to) what you want? There is already a function
> notmuch-show-get-depth.

that doesn't work in notmuch-tree buffers, which is where it's needed.
:depth is not even recorded as a message property there.  we can simply
rename :level to :depth as the new property there (although there's an
off-by-one difference in their values sometimes for implementation
details): since this will be in fact a brand new property in the
notmuch-tree buffer anyway, that shouldn't cause any trouble, right?
notmuch mailing list --
To unsubscribe send an email to