Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode

Subject: Re: [PATCH v7 1/1] emacs: notmuch-tree-outline-mode

Date: Tue, 13 Dec 2022 02:19:25 +0000

To: David Bremner

Cc: notmuch@notmuchmail.org

From: Jose A. Ortega Ruiz


On Mon, Dec 12 2022, Jose A. Ortega Ruiz wrote:

> took a second look, and yes, it's close but not quite.  there are cases
> (when the message is not the first but its depth is 0) where its outline
> level doesn't match the depth. we could store the depth and then repeat
> the computation everytime outline-mode requests the level, but it seems
> better to compute it only once, and also calling it something other than
> :depth, since they're not really the same thing.

I've just sent a new version of the patch (v8) in a separate email,
addressing (i think) most of the low-hanging fruit in your review,
David.  The parts missing are those needing work, i am afraid: better
documentation and tests.

HTH,
jao
-- 
The effort to understand the universe is one of the very few things
which lifts human life a little above the level of farce and gives it
some of the grace of tragedy. - Steven Weinberg
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: