Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

Date: Sun, 27 Nov 2011 21:30:11 -0500

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Austin Clements

Both patches look good to me.

(I don't think the compiler could warn about the unused `headers'
binding even if it wanted to because of dynamic scoping.)

• Previous message (by thread): Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

Thread:

• Dmitry Kurochkin—[PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, notmuch::patch, notmuch::pushed, unread]
  • Dmitry Kurochkin—[PATCH 2/2] emacs: remove unused variable in `notmuch-show-insert-part-message/rfc822' [inbox, notmuch::patch, notmuch::pushed, unread]
  • Austin Clements—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, notmuch::review, unread]
  • Jameson Graef Rollins—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, signed, unread]
    • Dmitry Kurochkin—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, unread]
    • Austin Clements—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, unread]
      • Jameson Graef Rollins—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, signed, unread]
  • Dmitry Kurochkin—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, unread]
  • David Bremner—Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show [inbox, unread]