Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

Subject: Re: [PATCH 1/2] emacs: remove some code duplication in notmuch-show

Date: Mon, 28 Nov 2011 06:24:19 -0800

To: Dmitry Kurochkin, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins


On Sat, 26 Nov 2011 02:23:30 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> -(defun notmuch-show-get-header (header)
> +(defun notmuch-show-get-header (header &optional props)
>    "Return the named header of the current message, if any."
> -  (plist-get (notmuch-show-get-prop :headers) header))
> +  (plist-get (notmuch-show-get-prop :headers props) header))

Hey, Dmitry.  It looks like the new plist-get call is assuming props is
defined, but it looks like it's only optional in the argument list.
Wouldn't the function fail if the props argument is not supplied?

jamie.
part-000.sig (application/pgp-signature)

Thread: