Re: [PATCH] add `tag:' prefix to `--output=tags' results

Subject: Re: [PATCH] add `tag:' prefix to `--output=tags' results

Date: Sun, 13 Nov 2011 16:14:35 +0200

To: David Bremner, Pieter Praet, notmuch@notmuchmail.org

Cc:

From: Jani Nikula

On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner <david@tethera.net> wrote:
> On Thu, 30 Jun 2011 10:20:29 +0200, Pieter Praet <pieter@praet.org> wrote:
> > Alter `do_search_tags()' to prepend each result with `tag:',
> > and update affected test.
> > 
> > This makes its output consistent with `do_search_threads()' and
> > `do_search_messages()'.
> 
> What do people think about this change? Personally I will have change
> some scripts to not add "tag:", but it isn't that big of a deal.

I'm curious why this change is needed in the first place. What is gained
from this in addition to consistency? It seems I don't have enough list
history to find the referenced discussion.

The command line interface is an API, and this change causes regressions
in all scripts and programs using it, including the emacs ui. (And that
should probably be fixed with something other than "...a quick'n'dirty
patch, thus probably not fit for consumption.")

BR,
Jani.

• Previous message (by thread): Re: [PATCH] add `tag:' prefix to `--output=tags' results

Thread:

• Carl Worth—Inconsistent output from "notmuch search --output=<foo>" [inbox, unread]
  • Jameson Rollins—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
  • Sebastian Spaeth—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
    • David Edmondson—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
    • Carl Worth—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
      • Jameson Rollins—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
  • Michal Sojka—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, unread]
  • Sebastian Spaeth—Re: Inconsistent output from "notmuch search --output=<foo>" [inbox, signed, unread]
    • Pieter Praet—[PATCH] remove prefixes from `--output={threads,messages}' results [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Carl Worth—Re: [PATCH] remove prefixes from `--output={threads, messages}' results [inbox, signed, unread]
        • Pieter Praet—Re: [PATCH] remove prefixes from `--output={threads, messages}' results [inbox, unread]
    • Pieter Praet—[PATCH] add `tag:' prefix to `--output=tags' results [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Pieter Praet—[PATCH] fix breakage in `notmuch-hello-generate-tag-alist' due to `tag:' prefix [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Pieter Praet—[PATCH] fix breakage in `notmuch-select-tag-with-completion' due to `tag:' prefix [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Bremner—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
        • Jani Nikula—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
          • Pieter Praet—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
        • Jameson Graef Rollins—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, signed, unread]
          • Dmitry Kurochkin—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
          • Pieter Praet—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
      • David Edmondson—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, signed, unread]
        • Pieter Praet—Re: [PATCH] add `tag:' prefix to `--output=tags' results [inbox, unread]
    • Pieter Praet—[PATCH] emacs: add keybind and function to stash Message-ID without prefix [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
      • Pieter Praet—[PATCH] test: stashing in notmuch-{show,search} [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
        • David Bremner—Re: [PATCH] test: stashing in notmuch-{show,search} [inbox, unread]
          • Pieter Praet—[PATCH] test: emacs: tidy up "Stashing in notmuch-show" test [inbox, notmuch::patch, notmuch::pushed, notmuch::test, unread]
            • David Bremner—Re: [PATCH] test: emacs: tidy up "Stashing in notmuch-show" test [inbox, unread]