Re: [PATCH] add `tag:' prefix to `--output=tags' results

Subject: Re: [PATCH] add `tag:' prefix to `--output=tags' results

Date: Wed, 16 Nov 2011 12:28:13 +0100

To: Jameson Graef Rollins, David Bremner, notmuch@notmuchmail.org

Cc:

From: Pieter Praet


On Sun, 13 Nov 2011 15:00:56 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Sat, 12 Nov 2011 10:17:30 -0500, David Bremner <david@tethera.net> wrote:
> > What do people think about this change? Personally I will have change
> > some scripts to not add "tag:", but it isn't that big of a deal.
> 
> I would actually prefer to see the prefixes removed from the messages
> and threads output rather than see it added to the tags output.  I think
> that's the way to make the output most consistent.  When I ask for
> --output=messages I'm asking for the message ids of the messages, not
> for search terms for the messages.  I think it should be up to the
> consumer to add the prefix if they would like to construct search terms
> based on the output.
> 
> My 2 cents.  I would be happy to provide a patch to make that change if
> people agree to that behavior.
> 

I agree 100%.  Your rationale is as rational as they come, and the
change itself is really simple (patch available [1]), *but* do consider
the amount of tests (alot!) and third-party programs/scripts that would
need an update.

> jamie.


Peace

-- 
Pieter

[1] id:"1309421989-22410-1-git-send-email-pieter@praet.org"

Thread: