Re: [PATCH] remove prefixes from `--output={threads, messages}' results

Subject: Re: [PATCH] remove prefixes from `--output={threads, messages}' results

Date: Thu, 30 Jun 2011 09:24:12 -0700

To: Pieter Praet, notmuch@notmuchmail.org

Cc:

From: Carl Worth


On Thu, 30 Jun 2011 10:19:49 +0200, Pieter Praet <pieter@praet.org> wrote:
> Alter `do_search_threads()' and `do_search_messages()'
> to not prepend each result with `thread:' respectively `id:'.

My one concern here is that I've sometimes had a message-id without the
id prefix and run a command like this:

    notmuch search 1309421989-22410-1-git-send-email-pieter@praet.org

And I've gotten confused when I've received no output, (didn't I receive
that mail? what happened?).

But I think this is a separate bug where the right fix is to make any
search terms with no prefix search through *all* prefixed terms
generated from email content. This would allow us to also avoid indexing
some content twice, (currently we store subject, from, and to both with
a prefix and without a prefix).

-Carl

-- 
carl.d.worth@intel.com
part-000.sig (application/pgp-signature)

Thread: