Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Subject: Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Date: Fri, 30 Dec 2011 22:55:59 -0400

To: Kazuo Teramoto, notmuch@notmuchmail.org

Cc:

From: David Bremner

On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto <kaz.rag@gmail.com> wrote:
> g_mime_init already check for multiple initializations.
> ---
>  lib/index.cc       |    4 ----
>  lib/message-file.c |    4 ----
>  2 files changed, 0 insertions(+), 8 deletions(-)

Is this needed to fix the bug? It seems less futureproof to rely on
gmime to check for double initialization if we don't have to.

d

• Previous message (by thread): Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Thread:

• Kazuo Teramoto—Segmentation fault at gmime-iconv with python binding [attachment, inbox, notmuch::bug, notmuch::fixed, unread]
  • David Bremner—Re: Segmentation fault at gmime-iconv with python binding [inbox, unread]
    • Kazuo Teramoto—[PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
      • Kazuo Teramoto—[PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
          • Kazuo Teramoto—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
        • Austin Clements—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
        • David Bremner—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
          • Kazuo Teramoto—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
      • Kazuo Teramoto—[PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, unread]
          • Kazuo Teramoto—[PATCH] lib: call g_mime_init() from notmuch_database_open() [inbox, unread]
            • Kazuo Teramoto—[PATCH] lib: call g_mime_init() from notmuch_database_open() [inbox, notmuch::patch, notmuch::pushed, unread]
              • David Bremner—revised patch for gmime init, with test. [inbox, unread]
                • David Bremner—[PATCH v2 1/3] test: use file based comparison for search '*' test [inbox, notmuch::patch, notmuch::pushed, unread]
                • David Bremner—[PATCH v2 2/3] test: add two new messages to corpus with iso-8859-1 encoding [inbox, notmuch::patch, notmuch::pushed, unread]
                • David Bremner—[PATCH v2 3/3] lib: call g_mime_init() from notmuch_database_open() [inbox, notmuch::patch, notmuch::pushed, unread]
                • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
                  • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                    • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                      • Jameson Graef Rollins—Re: revised patch for gmime init, with test. [inbox, signed, unread]
                        • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                      • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
                    • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
          • Tomi Ollila—Re: [PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, unread]
      • Patrick Totzke—Re: [PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
        • Kazuo Teramoto—Re: [PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
    • Sebastian Spaeth—Re: Segmentation fault at gmime-iconv with python binding [inbox, signed, unread]