Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Subject: Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Date: Sat, 31 Dec 2011 03:07:16 -0000

To: David Bremner, notmuch@notmuchmail.org

Cc:

From: Kazuo Teramoto


On 2011-12-31T00:55:59, David Bremner wrote:

>On Fri, 30 Dec 2011 19:58:09 -0200, Kazuo Teramoto <kaz.rag@gmail.com> wrote:
>> g_mime_init already check for multiple initializations.
>> ---
>>  lib/index.cc       |    4 ----
>>  lib/message-file.c |    4 ----
>>  2 files changed, 0 insertions(+), 8 deletions(-)
>
>Is this needed to fix the bug? It seems less futureproof to rely on
>gmime to check for double initialization if we don't have to.
>

No its not. But if you decide to push only the other part we probably
need to add the initialization check to it, for consistency. I can send
another patch, would you like it?

Thread: