Re: [PATCH 0/2] Multiples calls of g_mime_init

Subject: Re: [PATCH 0/2] Multiples calls of g_mime_init

Date: Sat, 31 Dec 2011 01:30:28 -0000

To: Patrick Totzke, notmuch@notmuchmail.org, David Bremner

Cc:

From: Kazuo Teramoto

On 2011-12-30T23:16:47, Patrick Totzke wrote:

>It seeminly doesn't break things either and I'm all in favour of doing
>things right™.

And talking about doing things right, we probably need to call
g_mime_shutdown() too, one for every time we call g_mime_init(). I will
send a patch after I do some more tests.

>On a related note: It also doesn't fix the recent segfaults of the bindings
>that occur when you try to write to a locked database.
>cf "id:4eddf2b1.4288980a.0b74.5557@mx.google.com"
>

This still hit me. If I remember right when I did a test what is
happening is that the binding is trying to close the db, so we need a
check if the db is opened before trying to close it.

• Previous message (by thread): Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init

Thread:

• Kazuo Teramoto—Segmentation fault at gmime-iconv with python binding [attachment, inbox, notmuch::bug, notmuch::fixed, unread]
  • David Bremner—Re: Segmentation fault at gmime-iconv with python binding [inbox, unread]
    • Kazuo Teramoto—[PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
      • Kazuo Teramoto—[PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
          • Kazuo Teramoto—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
        • Austin Clements—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
        • David Bremner—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
          • Kazuo Teramoto—Re: [PATCH 1/2] lib: Remove unnecessary checks when calling g_mime_init [inbox, unread]
      • Kazuo Teramoto—[PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, notmuch::obsolete, notmuch::patch, unread]
        • David Bremner—Re: [PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, unread]
          • Kazuo Teramoto—[PATCH] lib: call g_mime_init() from notmuch_database_open() [inbox, unread]
            • Kazuo Teramoto—[PATCH] lib: call g_mime_init() from notmuch_database_open() [inbox, notmuch::patch, notmuch::pushed, unread]
              • David Bremner—revised patch for gmime init, with test. [inbox, unread]
                • David Bremner—[PATCH v2 1/3] test: use file based comparison for search '*' test [inbox, notmuch::patch, notmuch::pushed, unread]
                • David Bremner—[PATCH v2 2/3] test: add two new messages to corpus with iso-8859-1 encoding [inbox, notmuch::patch, notmuch::pushed, unread]
                • David Bremner—[PATCH v2 3/3] lib: call g_mime_init() from notmuch_database_open() [inbox, notmuch::patch, notmuch::pushed, unread]
                • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
                  • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                    • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                      • Jameson Graef Rollins—Re: revised patch for gmime init, with test. [inbox, signed, unread]
                        • David Bremner—Re: revised patch for gmime init, with test. [inbox, unread]
                      • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
                    • Pieter Praet—Re: revised patch for gmime init, with test. [inbox, unread]
          • Tomi Ollila—Re: [PATCH 2/2] lib: call g_mime_init from notmuch_database_open [inbox, unread]
      • Patrick Totzke—Re: [PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
        • Kazuo Teramoto—Re: [PATCH 0/2] Multiples calls of g_mime_init [inbox, unread]
    • Sebastian Spaeth—Re: Segmentation fault at gmime-iconv with python binding [inbox, signed, unread]