Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{, -search}'

Date: Mon, 15 Oct 2012 23:12:51 -0400

To: Mark Walters, Pieter Praet, David Bremner, Dmitry Kurochkin

Cc: Notmuch Mail

From: Ethan Glasser-Camp


Mark Walters <markwalters1009@gmail.com> writes:

> I like the use of separator rather than hard-wiring " or ". My personal
> preference would be to make that change but keep the two functions
> separate (my "C"ness makes me like functions that have clear return
> types!) But I am happy with the change too.

I agree with this comment. Especially in dynamic languages, it's a good
idea for each function to have only one return type.

Also, it seems that the commit message has a TAB character in it (",<TAB>-search").

Ethan

Thread: