Re: [PATCH] doc/python: correct wording around container complexity.

Subject: Re: [PATCH] doc/python: correct wording around container complexity.

Date: Tue, 18 Mar 2025 09:25:10 -0300

To: Jakub Wilk, notmuch@notmuchmail.org

Cc:

From: David Bremner


Jakub Wilk <jwilk@jwilk.net> writes:

> * Floris Bruynooghe <flub@devork.be>, 2025-02-24 21:04:
>>On Sat 22 Feb 2025 at 13:42 -0400, David Bremner wrote:
>>
>>> Based on a suggestion from Jakub Wilk.
>>> ---
>>>  bindings/python-cffi/notmuch2/__init__.py | 6 +++---
>>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/bindings/python-cffi/notmuch2/__init__.py b/bindings/python-cffi/notmuch2/__init__.py
>>> index f281edc1..b1cd21c1 100644
>>> --- a/bindings/python-cffi/notmuch2/__init__.py
>>> +++ b/bindings/python-cffi/notmuch2/__init__.py
>>> @@ -37,9 +37,9 @@ In these python bindings they have sometimes been exposed as
>>>  like :class:`collections.abc.Set` or :class:`collections.abc.Mapping`
>>>  etc.  This gives a more natural API to work with, e.g. being able to
>>>  treat tags as sets.  However it does mean that the
>>> -:meth:`__contains__`, :meth:`__len__` and frieds methods on these are
>>> -usually more and essentially O(n) rather than O(1) as you might
>>> -usually expect from Python containers.
>>> +:meth:`__contains__`, :meth:`__len__` and similar methods on these are
>>> +usually more expensive and essentially O(n) rather than O(1) as you might
>>> +expect from Python containers.
>>>  """
>>>
>>>  from notmuch2 import _capi
>>
>>
>>LGTM
>
> Looks good to me, too.
>
> -- 
> Jakub Wilk

Ah, that should have gone in 0.39. Oh well, applied to release and master.
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: