Re: [PATCH 1/7] go: Use iota in enum bindings

Subject: Re: [PATCH 1/7] go: Use iota in enum bindings

Date: Wed, 18 Jul 2012 22:36:48 +0200

Austin Clements <amdragon@MIT.EDU> writes:

> Hah.  I guess nobody has tried to modify a notmuch database using the
> Go bindings.
>
> Could this instead assign the constants to
> C.NOTMUCH_DATABASE_MODE_READ_ONLY, etc, rather than duplicating their
> values?  It would be nice to do that for the Status values as well
> (which are correctly using iota, at least).

yep.
I have a few fixes like that in my repo:
https://github.com/sbinet/notmuch/commits/dev/go-bindings/bindings/go/src/notmuch

https://github.com/sbinet/notmuch/commit/38713de1b90a29b66b2a7f310065a3ffcf527d9b#L1L88

-s

part-000.sig (application/pgp-signature)

Previous message (by thread): Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected

Thread:

Adrien Bustany—[PATCH 0/7] Various fixes for the Go bindings [inbox, unread]
- Adrien Bustany—[PATCH 1/7] go: Use iota in enum bindings [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH 1/7] go: Use iota in enum bindings [inbox, notmuch::review, unread]
    - Sebastien Binet—Re: [PATCH 1/7] go: Use iota in enum bindings [inbox, signed, unread]
- Adrien Bustany—[PATCH 2/7] go: Add missing MESSAGE_FLAG_EXCLUDED in Flag enum [inbox, notmuch::moreinfo, notmuch::patch, unread]
- Adrien Bustany—[PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, notmuch::review, unread]
    - Adrien Bustany—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
      - Austin Clements—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
        Adrien Bustany—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
        Austin Clements—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
  - Ethan Glasser-Camp—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
    - Adrien Bustany—Re: [PATCH 3/7] go: Allow notmuch objects to be garbage collected [inbox, unread]
- Adrien Bustany—[PATCH 4/7] go: Make Destroy functions safe to call several times [inbox, notmuch::moreinfo, notmuch::patch, unread]
- Adrien Bustany—[PATCH 5/7] go: Partially bind notmuch_database_upgrade [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH 5/7] go: Partially bind notmuch_database_upgrade [inbox, notmuch::review, unread]
- Adrien Bustany—[PATCH 6/7] go: Bind notmuch_database_find_message_by_filename [inbox, notmuch::moreinfo, notmuch::patch, unread]
- Adrien Bustany—[PATCH 7/7] go: Bind notmuch_thread_t functions [inbox, notmuch::moreinfo, notmuch::patch, unread]
  - Austin Clements—Re: [PATCH 7/7] go: Bind notmuch_thread_t functions [inbox, notmuch::review, unread]
- Austin Clements—Re: [PATCH 0/7] Various fixes for the Go bindings [inbox, notmuch::review, unread]
  - Adrien Bustany—Re: [PATCH 0/7] Various fixes for the Go bindings [inbox, unread]