Hi

I have now been through essentially the whole series (except the tests)
and broadly like it. Just to summarise my concerns from the individual
replies here:

What should insert do when interrupted and is it safe? I am not
knowledgeable enough to be confident about that.

I think some of the talloc allocations need their return values
checked. I am more worried about this here then in most of the rest of
notmuch as we are writing to the database (and even to the mailstore
itself).

My other concerns (code duplication with notmuch-tag.c and possible
deadlock in the tmp file code and file overwriting) are easily fixable

Best wishes

Mark




On Wed, 25 Jul 2012, Peter Wang <novalazy@gmail.com> wrote:
> This does nothing yet.
> ---
>  Makefile.local   |    1 +
>  notmuch-client.h |    3 +++
>  notmuch-insert.c |   27 +++++++++++++++++++++++++++
>  notmuch.c        |    3 +++
>  4 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 notmuch-insert.c
>
> diff --git a/Makefile.local b/Makefile.local
> index 296995d..950f046 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -282,6 +282,7 @@ notmuch_client_srcs =		\
>  	notmuch-config.c	\
>  	notmuch-count.c		\
>  	notmuch-dump.c		\
> +	notmuch-insert.c	\
>  	notmuch-new.c		\
>  	notmuch-reply.c		\
>  	notmuch-restore.c	\
> diff --git a/notmuch-client.h b/notmuch-client.h
> index f930798..edbd3ee 100644
> --- a/notmuch-client.h
> +++ b/notmuch-client.h
> @@ -132,6 +132,9 @@ int
>  notmuch_dump_command (void *ctx, int argc, char *argv[]);
>  
>  int
> +notmuch_insert_command (void *ctx, int argc, char *argv[]);
> +
> +int
>  notmuch_new_command (void *ctx, int argc, char *argv[]);
>  
>  int
> diff --git a/notmuch-insert.c b/notmuch-insert.c
> new file mode 100644
> index 0000000..0e061a0
> --- /dev/null
> +++ b/notmuch-insert.c
> @@ -0,0 +1,27 @@
> +/* notmuch - Not much of an email program, (just index and search)
> + *
> + * Copyright © 2012 Peter Wang
> + *
> + * This program is free software: you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation, either version 3 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program.  If not, see http://www.gnu.org/licenses/ .
> + *
> + * Author: Peter Wang <novalazy@gmail.com>
> + */
> +
> +#include "notmuch-client.h"
> +
> +int
> +notmuch_insert_command (void *ctx, int argc, char *argv[])
> +{
> +    return 1;
> +}
> diff --git a/notmuch.c b/notmuch.c
> index 477a09c..86239fd 100644
> --- a/notmuch.c
> +++ b/notmuch.c
> @@ -53,6 +53,9 @@ static command_t commands[] = {
>      { "new", notmuch_new_command,
>        "[options...]",
>        "Find and import new messages to the notmuch database." },
> +    { "insert", notmuch_insert_command,
> +      "[options...] [--] [+<tag>|-<tag> ...] < message",
> +      "Add a new message into the maildir and notmuch database." },
>      { "search", notmuch_search_command,
>        "[options...] <search-terms> [...]",
>        "Search for messages matching the given search terms." },
> -- 
> 1.7.4.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch