Re: [PATCH 01/18] cli: add stub for insert command

Subject: Re: [PATCH 01/18] cli: add stub for insert command

Date: Mon, 19 Nov 2012 23:34:35 +1100

To: Mark Walters

Cc: notmuch@notmuchmail.org

From: Peter Wang

On Sun, 18 Nov 2012 17:35:23 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> 
> Hi
> 
> I have now been through essentially the whole series (except the tests)
> and broadly like it. Just to summarise my concerns from the individual
> replies here:

Thanks for the review.

> 
> What should insert do when interrupted and is it safe? I am not
> knowledgeable enough to be confident about that.

Do you mean cleaning up stray files?  Otherwise I think we just return
an error code, and then it's the caller's responsibility.

> 
> I think some of the talloc allocations need their return values
> checked. I am more worried about this here then in most of the rest of
> notmuch as we are writing to the database (and even to the mailstore
> itself).

Will do.

Peter

• Previous message (by thread): Re: [PATCH 04/18] insert: copy stdin to Maildir tmp file

Thread:

• Peter Wang—[PATCH 01/18] cli: add stub for insert command [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 02/18] insert: open database [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 03/18] insert: open Maildir tmp file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 03/18] insert: open Maildir tmp file [inbox, notmuch::review, unread]
  • Peter Wang—[PATCH 04/18] insert: copy stdin to Maildir tmp file [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Ali Polatel—Re: [PATCH 04/18] insert: copy stdin to Maildir tmp file [inbox, notmuch::review, signed, unread]
  • Peter Wang—[PATCH 05/18] insert: move file from Maildir tmp to new [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 05/18] insert: move file from Maildir tmp to new [inbox, notmuch::review, unread]
      • Peter Wang—Re: [PATCH 05/18] insert: move file from Maildir tmp to new [inbox, unread]
        • Mark Walters—Re: [PATCH 05/18] insert: move file from Maildir tmp to new [inbox, unread]
  • Peter Wang—[PATCH 06/18] insert: add new message to database [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 06/18] insert: add new message to database [inbox, notmuch::review, unread]
  • Peter Wang—[PATCH 07/18] insert: add --folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 08/18] insert: check folder name [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 09/18] insert: apply default tags to new message [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 10/18] insert: parse command-line tag operations [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 10/18] insert: parse command-line tag operations [inbox, unread]
  • Peter Wang—[PATCH 11/18] insert: apply command-line tag operations [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 12/18] insert: add copyright line from notmuch-deliver [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 13/18] test: add tests for insert [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 14/18] man: document 'insert' command [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 14/18] man: document 'insert' command [inbox, unread]
  • Peter Wang—[PATCH 15/18] man: reference notmuch-insert.1 [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 16/18] insert: add --create-folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Mark Walters—Re: [PATCH 16/18] insert: add --create-folder option [inbox, unread]
  • Peter Wang—[PATCH 17/18] man: document insert --create-folder option [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Peter Wang—[PATCH 18/18] test: test insert --create-folder [inbox, notmuch::obsolete, notmuch::patch, unread]
  • Jameson Graef Rollins—Re: [PATCH 01/18] cli: add stub for insert command [inbox, signed, unread]
    • Peter Wang—Re: [PATCH 01/18] cli: add stub for insert command [inbox, unread]
    • David Bremner—Re: [PATCH 01/18] cli: add stub for insert command [inbox, unread]
  • Mark Walters—Re: [PATCH 01/18] cli: add stub for insert command [inbox, unread]
    • Peter Wang—Re: [PATCH 01/18] cli: add stub for insert command [inbox, unread]
      • Mark Walters—Re: [PATCH 01/18] cli: add stub for insert command [inbox, unread]