Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

Subject: Re: [PATCH 06/11] lib: Internal support for querying and creating ghost messages

Date: Sun, 05 Oct 2014 10:30:30 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner

Austin Clements <aclements@csail.mit.edu> writes:

> +	    message->flags &= ~(1 << NOTMUCH_MESSAGE_FLAG_GHOST);

What do you think about using bit set / clear / read macros?  I don't
insist, but I wonder if it would make this part more readable.

> +	else if (*i == "Tghost")
> +	    message->flags |= (1 << NOTMUCH_MESSAGE_FLAG_GHOST);
> +	else

It makes me faintly unhappy to have the prefix hardcoded here.
Not sure if there is a sensible solution.

Thread: