Quoth David Bremner on Oct 05 at 10:56 am: > Austin Clements <aclements@csail.mit.edu> writes: > > + if (new_features & NOTMUCH_FEATURE_GHOSTS) { > > + t_end = db->metadata_keys_end ("thread_id_"); > > + for (t = db->metadata_keys_begin ("thread_id_"); t != t_end; ++t) > > + ++total; > > + } > > It would be nice to have the comment below, or something like it, for > the loop above. /* The ghost message upgrade converts all thread_id_* * metadata values into ghost message documents. */ sound good? > > + /* Perform metadata upgrades. */ > > + > > + /* Prior to NOTMUCH_FEATURE_GHOSTS, thread IDs for missing > > + * messages were stored as database metadata. Change these to > > + * ghost messages. > > + */