Re: [PATCH 00/11] Add ghost messages and fix thread linking

Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking

Date: Sun, 05 Oct 2014 11:07:12 +0200

To: Austin Clements, notmuch@notmuchmail.org

Cc:

From: David Bremner


Austin Clements <aclements@csail.mit.edu> writes:

> This series modifies our database representation of messages that have
> been referenced by other messages, but for which we don't have the
> message itself.  Currently, we store this information as Xapian
> metadata, but this has several downsides for performance and
> complexity and results in hard-to-fix thread linking bugs.  This patch
> series implements "ghost messages", which replace this Xapian metadata
> with Xapian documents that look and act very much like regular message
> documents, but simply have no content.  This simplifies and speeds up
> our thread linking algorithm and fixes the currently broken thread
> linking test.

Other than some style / documentation quibbles already noted, 
the series looks good to me.

d

Thread: