Re: [PATCH] lib: Simplify close and codify aborting atomic section

Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section

Date: Wed, 24 Sep 2014 21:25:20 +0200

To: W. Trevor King

Cc: notmuch@notmuchmail.org

From: David Bremner


"W. Trevor King" <wking@tremily.us> writes:

>
> Sorry, I didn't phrase that very well.  The notmuch docs (as of this
> patch) explain that we don't commit if we're in an atomic block.  The
> Xapian docs also say that, *and* they say that if we're not in atomic
> block the close *does* try to commit.  I think that's worth mentioning
> in our close docs.

OK, I see what you mean. I think the fact that you have to close the
notmuch database (when not using begin/end atomic) to get a commit is
surprising for many people, so it would be nice to make that clearer
somehow.

d

Thread: