Re: [PATCH] lib: Simplify close and codify aborting atomic section

Subject: Re: [PATCH] lib: Simplify close and codify aborting atomic section

Date: Wed, 24 Sep 2014 22:13:31 +0200

To: W. Trevor King

Cc: notmuch@notmuchmail.org

From: David Bremner

"W. Trevor King" <wking@tremily.us> writes:

> On Wed, Sep 24, 2014 at 09:25:20PM +0200, David Bremner wrote:
>> I think the fact that you have to close the notmuch database (when
>> not using begin/end atomic) to get a commit is surprising for many
>> people, so it would be nice to make that clearer somehow.
>
> It looks like Xapian is GPLv2+, so we should just be able to
> copy/paste/edit the line I quoted from the Xapian docs.
>
> Cheers,
> Trevor

I think it would be better to write our own, not because of licensing
issues, but because the user of the notmuch API won't know what a xapian
commit is.

d

Thread: