On Mon, Sep 22, 2014 at 11:43:35AM -0400, Austin Clements wrote: > This patch simplifies notmuch_database_close to just call > Database::close. This works for both read-only and read/write > databases, takes care of committing changes, unifies the exception > handling path, and codifies aborting outstanding transactions. If we're dropping the flush call here, where will it be triggered instead? We'll need to flush/commit our changes to the database at some point before closing. Do clients now need an explicit flush/commit command (explicit, client-initiated flushes sound like a good idea to me). Cheers, Trevor -- This email may be signed or encrypted with GnuPG (http://www.gnupg.org). For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy