Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

Subject:Re: Bug?: notmuch-search-show-thread shows several threads; only one containing matching messages

Date:Mon, 30 Jan 2012 21:27:34 +0000

To:Gregor Zattler ,notmuch

Cc:

From:Mark Walters


On Mon, 30 Jan 2012 20:04:25 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
> Hi Pieter,
> * Pieter Praet <pieter@praet.org> [30. Jan. 2012]:
> > On Mon, 30 Jan 2012 00:42:14 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
> >> * Pieter Praet <pieter@praet.org> [26. Jan. 2012]:
> >>> On Thu, 26 Jan 2012 13:44:50 +0100, Gregor Zattler <telegraph@gmx.net> wrote:
> >>>>    |> [2] grep -I "^Message-Id:" /tmp/thread-I-m-interested-in.mbox |sed -e "s/Message-Id: <//I" -e "s/>$//" >really.mid
> >>>>    |>     grep -I -F really.mid rest.mbox
> >>>>    |>     --> no match
> >>> 
> [...]
> >>> Also, the '-F' option expects input on stdin, not a filename.
> >> 
> >> No, this is -F instead of -f and means --fixed-strings.
> >> 
> > And as I said, `-F' requires input on stdin, like this:
> > 
> >   `grep -F "$(cat really.mid)" rest.mbox'
> > 
> > Otherwise [1] you're grepping for the pattern 'really.mid' instead of
> > for the patterns specified *in* 'really.mid', so naturally, you aren't
> > getting any results.
> 
> *blush* you're right and I'm wrong.  I re-re-did the greps with
> with the same results (no hits at all).
> 
> [...]
> >>> Here's another couple of threads squashed into a single one:
> >>> - [O] [Use Question] Capture and long lines
> >>>   - id:"BANLkTikoF4tXuNLLufRzNSD6k2ZYs7sUcg@mail.gmail.com"
> >>> - [O] Worg update
> >>>   - id:"m1wrfiz3ch.fsf@tsdye.com"
> >>> - [O] Table formula to convert hex to dec
> >>>   - id:"20110724080054.GB16388@x201"
> >>> - [O] ICS import?
> >>>   - id:"20120125173421.GQ3747@x201"
> >>> 
> >>> 
> >>> AFAICT, none of them share Message-Id's...
> >> 
> >> Do you consider this a bug?
> >> 
> > 
> > I do.  No idea what causes it or how to fix it though... :)
> 
> First I thougt it' not a severe bug since one see's more not less
> messages in notmuch show buffer.  But later I realised one also
> sees less not more threads in notmuch search buffer and might not
> read certain notmuch threads because of "wrong" $Subject: in
> notmuch search buffer.

Hi

I think notmuch links two messages into the same thread if they have an
in-reply-to or reference header in common: i.e the messages reference a
common parent message.  (See comment in lib/database.cc "Even before a
message is added, it's pre-allocated thread ID is useful so that all
descendant messages that reference this common parent can be recognized
as belonging to the same thread.")

As far as I can see your grep tests haven't checked for that. 

Also, could you email me the mbox you had (I think you said that it was
a mailing list so all public) and I will take a look?

Thanks

Mark

Thread: