Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

Subject: Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

Date: Mon, 27 Feb 2012 21:52:38 -0400

To: David Edmondson, notmuch@notmuchmail.org

Cc: Antoine Beaupré

From: David Bremner


On Mon, 30 Jan 2012 10:16:01 +0000, David Edmondson <dme@dme.org> wrote:
> ---
>  emacs/notmuch-lib.el   |    9 +++++++++
>  emacs/notmuch-print.el |    8 ++++++--
>  emacs/notmuch-show.el  |    5 ++++-
>  emacs/notmuch.el       |   21 +++++++++------------
>  4 files changed, 28 insertions(+), 15 deletions(-)

Jameson and Antoine have asked for this patch to be reverted. As far as
I understand it the printing code actually crashes on blank subjects if
this patch is removed, so it seems to me that that (slightly) outweighs
the annoyance caused by printing [No Subject].  I don't find the
argument that different people are annoyed

I'd be willing to be convinced otherwise, but as it turns out the
question is somewhat academic; there have been enough changes that this
patch no longer reverts cleanly. So Someone (TM) will have to do some to
change the behaviour; it sounds like the sensible thing to do would be to move
notmuch-prettify-subject into notmuch-print.el and call it there.

d

Thread: