Re: [PATCH] emacs: Leave blank subjects alone by default.

Subject: Re: [PATCH] emacs: Leave blank subjects alone by default.

Date: Sun, 12 Feb 2012 12:51:00 -0800

To: David Edmondson, notmuch@notmuchmail.org

Cc:

From: Jameson Graef Rollins

On Mon,  6 Feb 2012 21:30:16 +0000, David Edmondson <dme@dme.org> wrote:
> Add `notmuch-blank-subject' to control how empty or whitespace only
> subjects are treated. The default behaviour is to leave them
> alone. The user can choose a string to use as a replacement.
> 
> Modify code that cannot handle blank subjects to use a fixed string.

Hey, David.  I still think this is a lot of unnecessary code to deal
with what seems to be an issue with notmuch-print.el only.  I honestly
just don't see the point of replacing blank subjects with some other
string in all these circumstances.

Can't we just revert the original patch and just provide the needed fix
to print.el alone?

jamie.

• Previous message (by thread): Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects.

Thread:

• David Edmondson—[PATCH 0/3] minor cleanup and improvements [inbox, unread]
  • David Edmondson—[PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing. [inbox, notmuch::obsolete, notmuch::patch, unread]
  • David Edmondson—[PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • David Edmondson—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
  • David Edmondson—[PATCH 0/3 v2] minor cleanup and improvements [inbox, unread]
    • David Edmondson—[PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • Austin Clements—Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness. [inbox, notmuch::review, unread]
        • David Edmondson—Re: [PATCH 1/3] emacs: Stop the `truncate-string-to-width' madness. [inbox, signed, unread]
    • David Edmondson—[PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing. [inbox, notmuch::patch, notmuch::pushed, notmuch::trivial, unread]
      • David Bremner—Re: [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing. [inbox, unread]
      • David Bremner—Re: [PATCH 2/3] emacs: Don't mark messages as "unsaved" when printing. [inbox, unread]
    • David Edmondson—[PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::obsolete, notmuch::patch, unread]
      • David Edmondson—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
        • Mark Walters—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, unread]
          • David Edmondson—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
      • Mark Walters—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::review, unread]
      • Austin Clements—Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::review, unread]
    • David Edmondson—Re: [PATCH 0/3 v2] minor cleanup and improvements [inbox, signed, unread]
  • David Edmondson—[PATCH 0/2 v2] minor cleanup and improvements [inbox, unread]
    • David Edmondson—[PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness. [inbox, notmuch::patch, notmuch::pushed, unread]
      • Austin Clements—Re: [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness. [inbox, notmuch::review, unread]
        • David Edmondson—Re: [PATCH 1/2 v2] emacs: Stop the `truncate-string-to-width' madness. [inbox, signed, unread]
    • David Edmondson—[PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::patch, notmuch::pushed, unread]
      • Austin Clements—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, notmuch::review, unread]
      • Jameson Graef Rollins—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
        • David Edmondson—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
          • Jameson Graef Rollins—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
            • David Edmondson—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
              • Jameson Graef Rollins—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
                • David Edmondson—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
        • Antoine Beaupré—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, signed, unread]
      • David Bremner—Re: [PATCH 2/2 v2] emacs: Prefer '[No Subject]' to blank subjects. [inbox, unread]
    • David Edmondson—Re: [PATCH 0/2 v2] minor cleanup and improvements [inbox, signed, unread]
    • David Bremner—Re: [PATCH 0/2 v2] minor cleanup and improvements [inbox, unread]
  • David Edmondson—[PATCH] emacs: Leave blank subjects alone by default. [inbox, notmuch::obsolete, notmuch::patch, unread]
    • Jameson Graef Rollins—Re: [PATCH] emacs: Leave blank subjects alone by default. [inbox, signed, unread]
  • David Edmondson—[PATCH v2] emacs: Leave blank subjects alone by default. [inbox, notmuch::patch, notmuch::stale, unread]
    • Mark Walters—Re: [PATCH v2] emacs: Leave blank subjects alone by default. [inbox, unread]