Re: [PATCH 1/3] test/emacs: add known broken test for hidden tags

Subject: Re: [PATCH 1/3] test/emacs: add known broken test for hidden tags

Date: Thu, 20 Jan 2022 15:49:41 -0400

To: Tomi Ollila, Gregor Zattler, Notmuch Mail

Cc:

From: David Bremner

David Bremner <david@tethera.net> writes:

> Gregor Zattler observed that tags could be unintentionally hidden in
> the "All tags" view, and Tomi Ollia worked out [2] that the issue was tags
> that only occured on excluded messages. This test reproduces that bug.
>
> [1]: id:87wox1vovj.fsf@len.workgroup
> [2]: id:m28t9faaim.fsf@guru.guru-group.fi

Applied the series to master, with two trivial changes: one to
indentation, one to capitalization.

Interdiff follows.

diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index cd7ac39c..9ac52c11 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -570,7 +570,7 @@ options will be handled as specified for
 					    (plist-get options :filter))))
 	 "\n")))
     (unless (= (notmuch--call-process-region (point-min) (point-max) notmuch-command
-				    t t nil "count" "--exclude=false" "--batch") 0)
+					     t t nil "count" "--exclude=false" "--batch") 0)
       (notmuch-logged-error
        "notmuch count --batch failed"
        "Please check that the notmuch CLI is new enough to support `count
diff --git a/test/T440-emacs-hello.sh b/test/T440-emacs-hello.sh
index d9d28f8e..842781a4 100755
--- a/test/T440-emacs-hello.sh
+++ b/test/T440-emacs-hello.sh
@@ -68,7 +68,7 @@ test_emacs '(notmuch-hello)
 notmuch tag -$tag '*'
 test_expect_equal_file $EXPECTED/notmuch-hello-long-names OUTPUT
 
-test_begin_subtest "All Tags show up"
+test_begin_subtest "All tags show up"
 tag=exclude_me
 notmuch tag +$tag '*'
 notmuch config set search.exclude_tags $tag
_______________________________________________
notmuch mailing list -- notmuch@notmuchmail.org
To unsubscribe send an email to notmuch-leave@notmuchmail.org

Thread: