Re: [PATCH 11/11] emacs: Support cid: references with shr renderer

Subject: Re: [PATCH 11/11] emacs: Support cid: references with shr renderer

Date: Sat, 24 Jan 2015 12:12:32 -0500

To: David Edmondson, notmuch@notmuchmail.org

Cc:

On Thu, 01 May 2014, David Edmondson <dme@dme.org> wrote:
> On Mon, Apr 21 2014, Austin Clements wrote:
>> +(defun notmuch-show--insert-part-text/html-shr (msg part)
>> +  ;; Make sure shr is loaded before we start let-binding its globals
>> +  (require 'shr)
>> +  (let ((dom (let (process-crypto notmuch-show-process-crypto)
>
> Missing brackets? (You let-bind both `process-crypto' and
> `notmuch-show-process-crypto' as nil.)

'Doh.  Thanks.

Previous message (by thread): Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text}

Thread:

Austin Clements—[PATCH 00/11] Improve charset and cid: handling [inbox, unread]
- Austin Clements—[PATCH 01/11] emacs: Remove redundant NTH argument from `notmuch-get-bodypart-content'. [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 01/11] emacs: Remove redundant NTH argument from `notmuch-get-bodypart-content'. [inbox, unread]
- Austin Clements—[PATCH 02/11] test: New tests for Emacs charset handling [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - Mark Walters—Re: [PATCH 02/11] test: New tests for Emacs charset handling [inbox, unread]
    - Austin Clements—Re: [PATCH 02/11] test: New tests for Emacs charset handling [inbox, unread]
      - Mark Walters—Re: [PATCH 02/11] test: New tests for Emacs charset handling [inbox, unread]
      - Tomi Ollila—Re: [PATCH 02/11] test: New tests for Emacs charset handling [inbox, unread]
- Austin Clements—[PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message' [inbox, notmuch::emacs, notmuch::patch, notmuch::pushed, unread]
  - David Bremner—Re: [PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message' [inbox, unread]
  - David Bremner—Re: [PATCH 03/11] emacs: Fix coding system in `notmuch-show-view-raw-message' [inbox, unread]
- Austin Clements—[PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store [inbox, unread]
    - Austin Clements—Re: [PATCH 04/11] emacs: Track full message and part descriptor in w3m CID store [inbox, unread]
- Austin Clements—[PATCH 05/11] emacs: Create an API for fetching parts as undecoded binary [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - David Bremner—Re: [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API [inbox, unread]
    - Austin Clements—Re: [PATCH 06/11] emacs: Remove broken `notmuch-get-bodypart-content' API [inbox, unread]
- Austin Clements—[PATCH 07/11] emacs: Return unibyte strings for binary part data [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - Mark Walters—Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} [inbox, unread]
    - Austin Clements—Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} [inbox, unread]
      - Mark Walters—Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} [inbox, unread]
        Austin Clements—Re: [PATCH 08/11] emacs: Support caching in notmuch-get-bodypart-{binary, text} [inbox, unread]
- Austin Clements—[PATCH 09/11] emacs: Use generalized content caching in w3m CID code [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 10/11] emacs: Rewrite content ID handling [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
- Austin Clements—[PATCH 11/11] emacs: Support cid: references with shr renderer [inbox, notmuch::emacs, notmuch::obsolete, notmuch::patch, unread]
  - David Edmondson—Re: [PATCH 11/11] emacs: Support cid: references with shr renderer [inbox, unread]
    - Austin Clements—Re: [PATCH 11/11] emacs: Support cid: references with shr renderer [inbox, unread]
- Tomi Ollila—Re: [PATCH 00/11] Improve charset and cid: handling [inbox, notmuch::review, unread]
- Mark Walters—Re: [PATCH 00/11] Improve charset and cid: handling [inbox, unread]
  - Austin Clements—Re: [PATCH 00/11] Improve charset and cid: handling [inbox, unread]