RE: [PATCH v3] VIM: Improve moving between messages in a thread

Subject: RE: [PATCH v3] VIM: Improve moving between messages in a thread

Date: Tue, 03 Feb 2015 00:44:02 +0100

To: Franz Fellner, Bartosz Telenczuk

Cc: notmuch@notmuchmail.org

From: Bartosz Telenczuk


> I think the API should be clear and easy to understand, because people will probably bind them to custom shortcuts. You should not have to think about what that weird extra parameter (-1, false, ...) means and go read the docs.

I agree. One might replace the parameter with a string like "prev" and "next".

> But I agree that the code duplication is not optimal. The code in Ians repo already has split out the ruby code. There is still code duplication. But that can easily be split out into a function on its own. 

That's the way to go.

Bartosz

Thread: